refactor: unify renderPage and callEndpoint in one single function
#7703
+323
−297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: astro
matthewp
approved these changes
Jul 18, 2023
bluwy
approved these changes
Jul 19, 2023
ematipico
force-pushed
the
refactor/render-route-try
branch
from
98a656a to
b502d66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR renames
tryRenderPagetotryRenderRouteand moves the rendering of pages and endpoints under this same very function.This requires refactoring inside the
core/app/indexmodule.In the next PR I will move files inside
core/render/devfolder inside thevite-plugin-astro-serverfolder.Testing
Updated current tests. Current CI should pass
Docs
N/A