Add new internal resolveConfig API
#7647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: astro
bluwy
commented
Jul 14, 2023
Comment on lines
+223
to
+225
| // NOTE: This function will be removed in a later PR. Renamed with "Legacy" suffix to make way | ||
| // for the new `resolveConfig` API. | ||
| async function resolveConfigLegacy( |
There was a problem hiding this comment.
Un-export as it's not used internally. Also rename to make way for new API name.
ematipico
approved these changes
Jul 14, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Note: This merges into the
js-apibranch while I work on these step-by-stepresolveConfigAPI. Does the same thing asopenConfig, but duplicating to easier migrate step-by-step.AstroInlineConfigtype. Ideally this will be the config type thedev/buildJS API will accept. ("inline" borrowed from Vite)resolveConfigPathto not accept the rawflags. Easier to divide between JS and CLI code.Testing
Existing tests should pass.
Docs
n/a. internal refactor.