Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Response not being cloneable by middleware #7623

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Conversation

matthewp
Copy link
Contributor

Changes

Testing

  • Updated middleware test with this test case.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2023

🦋 Changeset detected

Latest commit: 9c61f44

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 11, 2023
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@matthewp matthewp merged commit 86e19c7 into main Jul 11, 2023
@matthewp matthewp deleted the cloneable-response branch July 11, 2023 18:21
@astrobot-houston astrobot-houston mentioned this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Astro's Response objects can't be cloned on Node (dev server, adapter)
2 participants