Fix markdoc test fail in main #7459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can do this as line 97 also has this guard for each `importedModules`
🦋 Changeset detectedLatest commit: d6c2502 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
bholmesdev
approved these changes
Jun 23, 2023
|
Needs changeset though! |
Merged
|
I noted in the description that we don't need a changeset though 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix a small regression from #7381, where virtual modules are not properly detected as
importedModulesas they are represented as\0astro:content, but the URLs are/@id/__x00__astro:content.I fixed the issue by inverting the
/@id/handling to the URLs, so that we can compare directly.I made refactors along the way, the 3 commits each show step-by-step changes. The 3rd commit is the actual fix.
No changeset as it's fixing an unreleased bug.
Testing
Existing test should pass
Docs
n/a. bug fix.