Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error message for using Markdown component #7343

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Jun 8, 2023

Changes

  • Fixes [regression] Markdown component generates console error in 2.6 #7335
  • Previously, this error message relied on the function name of Astro.redirects. That function name changed which broke the error message.
  • Think we should just remove this error (which doesn't actually stop you from building). Because:
    • There's no way for an Astro component to know that the app is running in SSG or SSR mode.
    • We don't want to add one, especially not to accommodate this feature.
    • Very few people are still using this component.

Testing

Did not

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Jun 8, 2023

🦋 Changeset detected

Latest commit: 1c4e15f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the feat: markdown Related to Markdown (scope) label Jun 8, 2023
@matthewp matthewp merged commit 3d9a392 into main Jun 9, 2023
@matthewp matthewp deleted the markdown-component-ssr branch June 9, 2023 04:41
@astrobot-houston astrobot-houston mentioned this pull request Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: markdown Related to Markdown (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[regression] Markdown component generates console error in 2.6
2 participants