Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better dynamic route regex error #7339

Merged
merged 7 commits into from
Jun 8, 2023

Conversation

bholmesdev
Copy link
Contributor

@bholmesdev bholmesdev commented Jun 8, 2023

Changes

  • This adds a readable error when a dynamic route fails to validate.

Before

image

After

image

Testing

  • Manual testing that readable error throws

Docs

  • Add new error code

@bholmesdev bholmesdev requested a review from a team as a code owner June 8, 2023 16:33
@changeset-bot
Copy link

changeset-bot bot commented Jun 8, 2023

🦋 Changeset detected

Latest commit: f0f4e02

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 8, 2023
@bholmesdev bholmesdev force-pushed the fix/better-dynamic-route-regex-error branch from 32219eb to f0f4e02 Compare June 8, 2023 17:41
@bholmesdev bholmesdev merged commit e3271f8 into main Jun 8, 2023
@bholmesdev bholmesdev deleted the fix/better-dynamic-route-regex-error branch June 8, 2023 22:12
@astrobot-houston astrobot-houston mentioned this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants