Refactor some integration tests #7303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improve test speed from 2s to 1s
improve test speed from 2.6s to 30ms
improve test speed from 18s to 5s
|
github-actions
bot
added
pkg: astro
github-actions
bot
removed
the
pkg: integration
matthewp
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Each commit should show the isolated changes made.
No new tests are added or removed. This PR mostly shift things around to (hopefully) speed up the test.
The astro integration test previously took 4m28s, now it's 3m53s (ubuntu node16)
Testing
Existing tests should pass.
Docs
n/a