Fix injectRoute for SSR #7128
Merged
Fix injectRoute for SSR #7128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o enable injected routes with SSR
🦋 Changeset detectedLatest commit: 6ff44de The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
Co-authored-by: Emanuele Stoppa <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use manifest routes for SSR app manifest instead of page components to enable injected routes with SSR.
I don't know whether this is the right way to handle it, but it seemed logical to me looking at the data structures.
Changes
injectRoutedidn't work for SSR. Now the injected manifest reuses the routes form the manifest, which also included injected routes.Testing
One test added to the
ssr-dynamicsuiteDocs
Docs shouldn't be affected