Fix e2e flaky tests #7084
Merged
Fix e2e flaky tests #7084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: astro
matthewp
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
While working on #7074, I think I figured out the flaky tests. We were testing component interaction without waiting for it to completely hydrate.
I added a new
waitForHydrateutility that watches theastro-island'sssrattribute to be removed to know that the island has been hydrated. Thisssrremove behaviour is from here.This brings around 60-90s faster e2e tests as fewer retries are needed.
Testing
Ran e2e tests a few times locally.
Docs
n/a. internal test fix.