Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to remove peer dep warnings #6930

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Apr 28, 2023

Changes

  • Update dependencies to prevent the postcss peer dep warnings on install.
  • Also update the @sveltejs/vite-plugin-svelte dep as that removes the stats log clutter in the CI logs

There's one remaining peer dep warning though:

 WARN  Issues with peer dependencies found
packages/integrations/svelte
└─┬ svelte2tsx 0.5.11
  └── ✕ unmet peer typescript@^4.1.2: found 5.0.2

We need to upgrade to svelte2tsx v6 to fix it, but that bumps the peer dep of svelte to 3.55.0. Our svelte peer dep is 3.54.0. So we'd need to cut a major if we want to fix it, which doesn't seem worth it for now.

Testing

Existing tests should pass.

Docs

n/a. deps update

@changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2023

🦋 Changeset detected

Latest commit: 356a167

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) pkg: svelte Related to Svelte (scope) pkg: integration Related to any renderer integration (scope) labels Apr 28, 2023
@Princesseuh
Copy link
Member

Princesseuh commented Apr 28, 2023

fwiw, the typescript dep of svelte2tsx in our context is optional, we only use it in contexts where the user provide TypeScript themselves

@bluwy bluwy merged commit 2dca81b into main Apr 28, 2023
@bluwy bluwy deleted the update-peer-warning-deps branch April 28, 2023 13:21
@astrobot-houston astrobot-houston mentioned this pull request Apr 28, 2023
RaphaelBossek pushed a commit to RaphaelBossek/my.astro.build that referenced this pull request Apr 29, 2023
RaphaelBossek pushed a commit to RaphaelBossek/my.astro.build that referenced this pull request Apr 29, 2023
RaphaelBossek pushed a commit to RaphaelBossek/my.astro.build that referenced this pull request Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope) pkg: svelte Related to Svelte (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants