Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade undici to v5.22.0 #6929

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Upgrade undici to v5.22.0 #6929

merged 1 commit into from
Apr 28, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Apr 28, 2023

Changes

Bump undici to hopefully reduce the fetch failed errors that sometimes happen in CI.

Testing

Existing tests should pass.

Docs

n/a

@changeset-bot
Copy link

changeset-bot bot commented Apr 28, 2023

🦋 Changeset detected

Latest commit: 792b8b6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) labels Apr 28, 2023
Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reasons it added a new dep instead of replacing 5.20.0?

@bluwy
Copy link
Member Author

bluwy commented Apr 28, 2023

It looks like some Cloudflare dependencies still rely on undici 5.20.0. I tried pnpm update undici -r but it doesn't seem to update the internal nested deps, so not touching those for now to keep the scope down.

@bluwy bluwy merged commit ac57b55 into main Apr 28, 2023
@bluwy bluwy deleted the bump-undici branch April 28, 2023 13:13
@astrobot-houston astrobot-houston mentioned this pull request Apr 28, 2023
RaphaelBossek pushed a commit to RaphaelBossek/my.astro.build that referenced this pull request Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants