Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changeset publish #6923

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Fix changeset publish #6923

merged 2 commits into from
Apr 27, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Apr 27, 2023

Changes

Use package.json workspaces field to configure changesets like before. And make sure test packages have {"private": true}

Testing

Ran pnpm changeset version --dry-run, pnpm changeset publish --dry-run, pnpm changeset

Docs

n/a

@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2023

⚠️ No Changeset found

Latest commit: 48aeda5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: integration Related to any renderer integration (scope) labels Apr 27, 2023
@@ -6,7 +6,6 @@
"access": "public",
"baseBranch": "main",
"updateInternalDependencies": "patch",
"ignore": ["!(astro|create-astro|@astrojs/*|astro-scripts)"],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed because the workspaces field only captures packages that we want to publish, otherwise changeset would error on unused ignores.

@bluwy bluwy merged commit de5a25f into main Apr 27, 2023
@bluwy bluwy deleted the fix-changeset-again branch April 27, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants