Handle Vite 4.3 module graph changes #6716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9c0551d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
Closing as the Vite change will happen in Vite 5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
DRAFT until the Vite PR is merged
Handle the changes for vitejs/vite#11973
We use the module graph to scan for CSS to prevent FOUC. We crawl it using
mod.importedModules, but the field is meant for client-side imports only. Vite had mixed it with SSR and is now un-mixing it in vitejs/vite#11973.Although this feels like a breaking change, I think it can be justified that we should've used
mod.ssrTransformResult.depsinstead for SSR stuff, and thatmod.importedModuleswere only supposed to be client-side only.Vite 4.3 will introduce
mod.ssrImportedModulesinstead so I've updated to anticipate it when we upgrade to Vite 4.3.Testing
Existing tests should pass. Though we're not using Vite 4.3 yet, vite-ecosystem-ci will test against it.
Docs
n/a. bug fix.