-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose partytown config options from astro plugin #6667
Conversation
🦋 Changeset detectedLatest commit: 399b910 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a nice harmless change to me 👍
Thank you, @bluwy, for the review. I did change the doc and have squashed the history to make it cleaner. Happy with the current state of it, so, let me know if you need anything more from my side before the merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion
Bump minor version Remove unused import docs fix: use the nullish coalescing operator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @thebinarymutant, docs LGTM!
Changes
Testing
I didn't see any test's setup for the package. Do we need one?
Docs
Removed the content that explicitly mentioned about the
debug
andforward
properties.