Content Collections: remove data and body from custom slug()
#5921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f824fe4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
matthewp
approved these changes
Jan 21, 2023
|
Closing in favor of #5941 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
dataandbodyfrom the customslug()configuration optionWhy remove this?
Allowing access to the parsed Zod schema introduces a bottleneck when looking up entries by slug. Today, this function is slower than we'd like it to be, since it needs to look through all items in a collection to give you the right one. By allowing access to the data object, it is more difficult (though not impossible) to make this function more performant in a non-breaking way.
We recognize the usefulness of looking up entries by custom
dataattributes. However, for the most performant and futureproof story in Astro 2.0, removing this to revisit in a future minor feels like the best path.Testing
Update tests expecting
dataDocs
TODO: docs updates