Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup deprecated Markdown APIs from 0.X #5891

Merged
merged 7 commits into from
Jan 18, 2023
Merged

Cleanup deprecated Markdown APIs from 0.X #5891

merged 7 commits into from
Jan 18, 2023

Conversation

bholmesdev
Copy link
Contributor

Changes

  • Remove content.astro warning messages
  • Remote deprecated getHeaders() function
  • Remove rawContent() and compiledContent() errors from MDX and type signature. Users expect that checking file.rawContent === undefined will allow safe calling on MD and MDX files. By exporting these functions just to throw errors, we made it harder to use them safely!

Testing

Docs

All deprecated APIs, so no docs changes!

@bholmesdev bholmesdev requested a review from a team as a code owner January 18, 2023 14:03
@changeset-bot
Copy link

changeset-bot bot commented Jan 18, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 1a41c2e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) labels Jan 18, 2023
@sarah11918 sarah11918 removed the request for review from a team January 18, 2023 14:24
@bholmesdev bholmesdev merged commit 05caf44 into main Jan 18, 2023
@bholmesdev bholmesdev deleted the fix/md-cleanup branch January 18, 2023 22:04
@astrobot-houston astrobot-houston mentioned this pull request Jan 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bholmesdev @matthewp