Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix importing client-side components with alias #5845

Merged
merged 2 commits into from
Jan 14, 2023
Merged

Fix importing client-side components with alias #5845

merged 2 commits into from
Jan 14, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jan 13, 2023

Changes

fix #5821

Add a Vite plugin to resolve aliases for client build input entries.

This is a workaround for now until the upstream Rollup fix: rollup/plugins#1402

Testing

Added a test for alias build. There was only dev.

Docs

n/a. bug fix.

@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2023

🦋 Changeset detected

Latest commit: b672f77

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 13, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix, thanks for tracking this upstream!

@bluwy bluwy merged commit e818cc0 into main Jan 14, 2023
@bluwy bluwy deleted the fix-alias-input branch January 14, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client-side assets build fails when using import aliases
2 participants