Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Content Collections] Fix import.meta.env.DEV always set to true #5700

Merged
merged 3 commits into from
Jan 3, 2023

Conversation

bholmesdev
Copy link
Contributor

Changes

Testing

Manual testing

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Dec 29, 2022

🦋 Changeset detected

Latest commit: 04ab4b9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Dec 29, 2022
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Vite 4 doesn't mutate NODE_ENV anymore so this trick won't be needed in Astro 2.0, but it's still good to fix this in Astro 1.0 for now. It will be handled here 166ce32

@bholmesdev bholmesdev force-pushed the fix/content-collections-always-dev-mode branch from d344d75 to 04ab4b9 Compare January 2, 2023 15:43
@bholmesdev bholmesdev merged commit 3aa3e00 into main Jan 3, 2023
@bholmesdev bholmesdev deleted the fix/content-collections-always-dev-mode branch January 3, 2023 14:45
@astrobot-houston astrobot-houston mentioned this pull request Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import.meta.env.DEV env always true when using content collections feature
2 participants