Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing guide test-running examples #5590

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

mattstein
Copy link
Contributor

Existing example doesn’t work because RSS is handled in a separate package. (See Discord.)

Changes

This is a simple Markdown edit that changes pnpm run test:match example to one that works, adds an example of package filtering using that previous RSS case.

Testing

Example commands were tested locally, but there’s too much irony in the fact that I can’t test the docs related to testing.

Docs

This is a documentation update. 😎

Changes `pnpm run test:match` example to one that works, adds an example of package filtering using that previous RSS case.
@changeset-bot
Copy link

changeset-bot bot commented Dec 12, 2022

⚠️ No Changeset found

Latest commit: f247530

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏻 Thanks for the PR!

@natemoo-re natemoo-re merged commit 2b11e97 into withastro:main Dec 14, 2022
@mattstein mattstein deleted the patch-1 branch December 14, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants