Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deno integration dependencies #5573

Merged
merged 2 commits into from
Dec 10, 2022
Merged

Conversation

lino-levan
Copy link
Contributor

Changes

  • Bumps the deno_std dependency to be up to date

Testing

  • No new tests are required since we are just changing the dependency version

Docs

  • I have also updated the dependency in the docs

@lino-levan lino-levan requested a review from a team as a code owner December 9, 2022 17:35
@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2022

⚠️ No Changeset found

Latest commit: 201aba5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lino-levan
Copy link
Contributor Author

Failing tests are unrelated to this change and look to be flaky?

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good 👍

@matthewp
Copy link
Contributor

matthewp commented Dec 9, 2022

@lino-levan Yeah, likely a flakey test, I'll rerun it. Thank you!

@lino-levan
Copy link
Contributor Author

super weird... it looks like the failing test isn't erroring out but instead timing out. Wondering if there was a performance regression of astro somewhat recently that's causing the test to fail sometimes?

@delucis
Copy link
Member

delucis commented Dec 9, 2022

Just tried re-running the failing test. Let’s see what happens 🤞

@lino-levan
Copy link
Contributor Author

Cool, looks like that worked. Thanks @delucis!

@matthewp
Copy link
Contributor

Closes #5565

@matthewp matthewp merged commit 5b323b9 into withastro:main Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants