Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing fetchpriority attribute to ImgHTMLAttributes #5433

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Add missing fetchpriority attribute to ImgHTMLAttributes #5433

merged 1 commit into from
Nov 17, 2022

Conversation

wtchnm
Copy link
Contributor

@wtchnm wtchnm commented Nov 17, 2022

Changes

Add missing fetchpriority attribute to ImgHTMLAttributes. See https://wicg.github.io/priority-hints/#img.

Testing

N/A

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2022

🦋 Changeset detected

Latest commit: b5be36e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 17, 2022
@Princesseuh
Copy link
Member

Thank you for this contribution! Could you also add the attribute to the other supported elements?

  • link (LinkHTMLAttributes)
  • script (ScriptHTMLAttributes)
  • iframe (IframeHTMLAttributes))

Thank you very much!

@wtchnm
Copy link
Contributor Author

wtchnm commented Nov 17, 2022

Done, thanks @Princesseuh!

Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thank you!

@Princesseuh Princesseuh merged commit 936c1e4 into withastro:main Nov 17, 2022
@astrobot-houston astrobot-houston mentioned this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants