fix: partytown base path #5425
Merged
fix: partytown base path #5425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8171da3 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
|
Thanks @brenelz! Can you add a changeset? |
Okay I've added one. Hopefully I did it right |
1 task
Merged
|
Still seeing the issue mentioned in #5424: Is this something else? |
|
@joshuaiz Did you solve this, I am seeing this exact error now.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #5424
Changes
When serving up the partytown-sandbox-sw.js it is already scoped to the base path. The code that matches the request url is at the following.
https://github.com/withastro/astro/blob/main/packages/integrations/partytown/src/sirv.ts#L209
Testing
I was able to reproduce the problem locally and then tinkered around a bit until I figured out the problem. Might need some more tesing since I am still very new.
Docs
Shouldn't have any effect on the docs. It is just a fix with the expected behavior.