Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use base rather than site to create subpath for links/scripts #5371

Merged
merged 5 commits into from
Nov 11, 2022

Conversation

matthewp
Copy link
Contributor

Changes

Testing

  • Added tests

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2022

🦋 Changeset detected

Latest commit: 3fce7e4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 11, 2022
@matthewp matthewp marked this pull request as ready for review November 11, 2022 18:52
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice warning

@matthewp matthewp merged commit bee8c14 into main Nov 11, 2022
@matthewp matthewp deleted the site-used-as-base branch November 11, 2022 19:34
@astrobot-houston astrobot-houston mentioned this pull request Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pathname of site in config file used for asset resolution in build
2 participants