Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 when not using subpath for items in public in dev #5328

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Nov 8, 2022

Changes

Testing

Tests added for both base and non-base scenarios.

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2022

🦋 Changeset detected

Latest commit: 4777867

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 8, 2022
@matthewp matthewp marked this pull request as ready for review November 8, 2022 18:09
packages/astro/test/units/dev/dev.test.js Show resolved Hide resolved
.changeset/plenty-eyes-develop.md Show resolved Hide resolved
@github-actions github-actions bot added the semver: minor Change triggers a `minor` release label Nov 8, 2022
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@matthewp matthewp merged commit bcd0f8f into main Nov 9, 2022
@matthewp matthewp deleted the base-dev branch November 9, 2022 13:30
@astrobot-houston astrobot-houston mentioned this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) semver: minor Change triggers a `minor` release
Projects
None yet
2 participants