Http proxy for fetch #4676
Merged
Http proxy for fetch #4676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing on |
|
@zicklag main is passing now, so if you want to rebase your branch it should be good, sorry about that. |
zicklag
force-pushed
the
http-proxy-for-fetch
branch
from
7a4e2a1 to
9290b24
Compare
🦋 Changeset detectedLatest commit: baecdfa The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Sorry for the close, I accidentally pushed Just rebased, and no problem at all about the failures. :D |
Use `global-agent` to support HTTP_PROXY, HTTPS_PROXY, and NO_PROXY environment variables.
zicklag
force-pushed
the
http-proxy-for-fetch
branch
from
c76e465 to
baecdfa
Compare
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fetchbehind an HTTP proxy.HTTP_PROXY,HTTPS_PROXY, andNO_PROXYenvironment variables.Testing
There are no additional tests. We could potentially add tests, but it would require standing up an HTTP proxy to test through during the test, which might be non-trivial.
It would be up to your discernment whether or not we need to pursue that.
Docs
We should add a section to the docs about use behind HTTP proxies. Especially because most things that support HTTP proxies will read both the uppercase environment variables, and the lowercase environment variables, but the
global-agentpackage I used to support proxies here only supports the uppercase environment variables, so that could be a gotcha, for some people. ( It almost was for me. )