-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix namespaced component usage in MDX #4272
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dfa3519 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
Related to the core `astro` package (scope)
pkg: example
Related to an example package (scope)
pkg: integration
Related to any renderer integration (scope)
labels
Aug 11, 2022
Blocked by withastro/compiler#497 |
natemoo-re
force-pushed
the
fix/namespaced
branch
from
August 12, 2022 19:07
9cb5cb2
to
f4962c4
Compare
github-actions
bot
removed
the
pkg: example
Related to an example package (scope)
label
Aug 12, 2022
matthewp
approved these changes
Aug 12, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg: astro
Related to the core `astro` package (scope)
pkg: integration
Related to any renderer integration (scope)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
astro-island
couldn't handle a namespace more than one.
deep. Fixed this as well.Testing
Added E2E test to verify hydration works, added MDX test to verify build and dev includes correct
script
Docs
Bug fix only