Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not resolve renderer.serverEntrypoint url before loading it #4143

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

FredKSchott
Copy link
Member

@FredKSchott FredKSchott commented Aug 4, 2022

Changes

  • Followup to fix windows package export #4141 to attempt a fix for one of the two Windows issues: renderer. serverEntrypoint
  • Vite 3 appears to not like having resolved package exports passed to ssrLoadModule (but only on Windows?) and instead expects the unresolved package entrypoint.
  • This is only safe to remove if we can confirm that the bug that this comment is referencing is out of date. I've confirmed that this change runs fine in the examples, but unclear which exact issue it was addressing since this is only ever used for loading renderers. @bholmesdev maybe you remember?

Testing

  • Unclear if this is covered by existing tests or not. @bholmesdev to confirm?

Docs

  • N/A

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2022

⚠️ No Changeset found

Latest commit: 7c615ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 4, 2022
@matthewp
Copy link
Contributor

matthewp commented Aug 5, 2022

The commit where this was previously changed is here: 098f6f6

That commit was a workaround for an underlying Vite bug that resurfaced and was ultimately fixed here: vitejs/vite#8533. So I think we can merge this change.

@bholmesdev
Copy link
Contributor

That bug @matthewp linked looks familiar to me! I agree this should be fixed with the new isSelfAccepting behavior. Pretty comfortable merging with these passing tests 👍

@FredKSchott FredKSchott merged commit 2f0b823 into main Aug 5, 2022
@FredKSchott FredKSchott deleted the fix-windows-import-3 branch August 5, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants