Throw the error when site option is missing
#3956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f90a431 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks @esafev, this looks great and should really help non-TS users. |
FredKSchott
approved these changes
Jul 18, 2022
Merged
Yep, I use Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Recently, I faced a problem when the
RSSplugin threw an error that saidCannot read properties of undefined (reading 'replace')#3846, and this flaw was fixed in this PR #3498In my case, bumping the version helped, but I spent some time understanding what was wrong and found the above issues. Therefore, I added a throwing error which returns a more expected stacktrace for cases when
siteoption was not included.Testing
Added a test for checking that exception return corrected.
Docs
No docs changed, small DX improve.