Move client types into Astro #3851
Conversation
🦋 Changeset detectedLatest commit: f8e771e The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
github-actions
bot
added
the
pkg: integration
github-actions
bot
removed
the
pkg: integration
There was a problem hiding this comment.
Looking' good! All the examples still say "// Add type definitions for our Vite runtime." above astro/client, though. Would remove or rephrase that.
Agree with @Princesseuh about making sure the docs get updated. Also roping in @tony-sull to comment on the image types.
| // images | ||
| declare module '*.jpg' { | ||
| const src: string | ||
| export default src | ||
| } | ||
| declare module '*.jpeg' { | ||
| const src: string | ||
| export default src | ||
| } | ||
| declare module '*.png' { | ||
| const src: string | ||
| export default src | ||
| } |
There was a problem hiding this comment.
I think this means @tony-sull can override these now?
There was a problem hiding this comment.
By override do you mean change them, then sure. If you mean override in his project, I'm not enough of a TS guru to know.
There was a problem hiding this comment.
I think typescript will let @astrojs/image re-declare these, but I'm not 100% sure. @matthewp the main need is for @astrojs/image to be able to define all image imports to something similar to
declare module '*.jpeg' {
const metadata: {
src: string
width: number
height: number
format: string
}
export default metadata
}There was a problem hiding this comment.
I believe adding these to a @astrojs/image/client.d.ts file and then adding that to compilerOptions.include will override these. We don't want this to reference the @astrojs/image types unless @astrojs/image is installed.
|
Docs updated in this PR: withastro/docs#953 |
* Move client types into Astro * Adds a changeset * Fix path to local client * Reference vite/client in our HMR types * Add back in the expect-error * Update types comment
Changes
vite/clientwithastro/client.astro/clientdoesn't contain DOM references, so you don't get weird DOM types in your frontmatter.Testing
Docs