Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying entryFileNames for client JS #3676

Merged
merged 3 commits into from
Jun 22, 2022
Merged

Conversation

matthewp
Copy link
Contributor

Changes

  • Fixes 🐛 BUG:Error occured on adding 'entryFileNames' #3672
  • We need to specify the server entry point, so when you try to define entryFileNames in your own config that causes the build to fail.
  • Fix is to make sure our entryFileNames is used for the server code, but not for client.

Testing

  • Tests added

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2022

🦋 Changeset detected

Latest commit: 220d800

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 22, 2022
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense! Nice fix.

Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One comment just to double check I understand how this works with adapters

packages/astro/test/entry-file-names.test.js Show resolved Hide resolved
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@matthewp matthewp merged commit 85c3375 into main Jun 22, 2022
@matthewp matthewp deleted the entry-file-names branch June 22, 2022 16:32
@github-actions github-actions bot mentioned this pull request Jun 22, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Allow specifying entryFileNames for client JS

* Adds a changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG:Error occured on adding 'entryFileNames'
3 participants