Allow TypeScript in hoisted scripts #3665
Conversation
🦋 Changeset detectedLatest commit: c209c8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
Not sure if needed, but I think a test for importing files with various extensions (no extension, js extension for ts file etc) should be added since that's been a common issue inside the frontmatter |
| interface Props { | ||
| name: string; | ||
| } |
There was a problem hiding this comment.
Ooh is the compiler ready for this? We follow 4.12.1.3 so I think generics should be fine...
Would be nice to test! LMK if you think that should be in the compiler rather than here.
There was a problem hiding this comment.
Not sure I follow, this is tested, this file is a test file.
|
@Princesseuh added tests for imports. Thanks for suggesting that, needed to make that work. |
| @@ -1,3 +1,11 @@ | |||
| <script> | |||
| console.log('some content here.'); | |||
| import '../scripts/some-files/one'; | |||
| import '../scripts/some-files/two.ts'; | |||
There was a problem hiding this comment.
Missing a .js import for a ts file (ex, one.js for one.ts)
github-actions
bot
added
🚨 action
|
Need to check something in the rollup docs before merging this. |
* Allow TypeScript in hoisted scripts * Pass skipSelf * Fix linting
Changes
&lang.tsto the module id of hoisted scripts. This makes it so that Vite treats these are TypeScript.Testing
Docs
N/A, bug fix.