Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base config option to partytown snippet generation #3437

Merged
merged 3 commits into from
May 24, 2022

Conversation

caioferrarezi
Copy link
Contributor

@caioferrarezi caioferrarezi commented May 24, 2022

Changes

Testing

Tested locally

Docs

There's no need to update the docs.

@changeset-bot
Copy link

changeset-bot bot commented May 24, 2022

🦋 Changeset detected

Latest commit: f737e4c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/partytown Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label May 24, 2022
@caioferrarezi caioferrarezi changed the title fix: add base config option to partytown snippet generation Add base config option to partytown snippet generation May 24, 2022
@caioferrarezi caioferrarezi marked this pull request as ready for review May 24, 2022 18:10
@caioferrarezi
Copy link
Contributor Author

@natemoo-re can you review it, please? :D

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the quick PR!

@natemoo-re natemoo-re merged commit 78e962f into withastro:main May 24, 2022
@github-actions github-actions bot mentioned this pull request May 24, 2022
@caioferrarezi caioferrarezi deleted the fix-partytown-script branch May 24, 2022 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Partytown's Integration does not respect Astro's base config option
2 participants