Implement new default script behavior, style is:global
#2961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7e5fd85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
added 2 commits
April 2, 2022 12:25
Merged
zadeviggers
added a commit
to zadeviggers/docs
that referenced
this pull request
Apr 2, 2022
FredKSchott
added a commit
to withastro/docs
that referenced
this pull request
Apr 12, 2022
* create page Signed-off-by: Zade Viggers <[email protected]> * move hydration directives documentation to directives reference page Signed-off-by: Zade Viggers <[email protected]> * add fragment to directives reference page Signed-off-by: Zade Viggers <[email protected]> * add script and style tag directives Signed-off-by: Zade Viggers <[email protected]> * add set:html and set:text Signed-off-by: Zade Viggers <[email protected]> * add directives reference page to sidebar Signed-off-by: Zade Viggers <[email protected]> * add hoist example & improve define:vars warning Signed-off-by: Zade Viggers <[email protected]> * update headings to be more uniform Signed-off-by: Zade Viggers <[email protected]> * create page Signed-off-by: Zade Viggers <[email protected]> * move hydration directives documentation to directives reference page Signed-off-by: Zade Viggers <[email protected]> * add fragment to directives reference page Signed-off-by: Zade Viggers <[email protected]> * add script and style tag directives Signed-off-by: Zade Viggers <[email protected]> * add set:html and set:text Signed-off-by: Zade Viggers <[email protected]> * add directives reference page to sidebar Signed-off-by: Zade Viggers <[email protected]> * add hoist example & improve define:vars warning Signed-off-by: Zade Viggers <[email protected]> * update headings to be more uniform Signed-off-by: Zade Viggers <[email protected]> * Add is:raw * Move is:raw * Add scetion descriptions * document global directive Signed-off-by: Zade Viggers <[email protected]> * document class:list directive Signed-off-by: Zade Viggers <[email protected]> * fix formatting Signed-off-by: Zade Viggers <[email protected]> * Add info about how class:list is passed to children. * Add information to top of page * Fix typo * Clean up page a bit * Add note about `class:list` not working with expressions * make links to directives reference page consistet with the rest of the docs Signed-off-by: Zade Viggers <[email protected]> * update to be consistent with new script and style behavior ([#2961](withastro/astro#2961)) * move universal directives to the top of the page Signed-off-by: Zade Viggers <[email protected]> * change framework components page a little Signed-off-by: Zade Viggers <[email protected]> * better description at top of page * add link to styling page * add note about is:text being redundent Signed-off-by: Zade Viggers <[email protected]> * make is:raw description clearer Signed-off-by: Zade Viggers <[email protected]> * move warnings below example code Signed-off-by: Zade Viggers <[email protected]> * fix typo Signed-off-by: Zade Viggers <[email protected]> * another typo Signed-off-by: Zade Viggers <[email protected]> * fix fragment from old draft Signed-off-by: Zade Viggers <[email protected]> Co-authored-by: Fred K. Schott <[email protected]>
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
…#2961) * feat: implement RFC0016 * chore: update to latest compiler * chore: update compiler * test: fix script tests * test: update public tests * feat: throw a warning when referencing scripts in `public/` without `is:inline`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
is:inlineandis:globalTesting
Tests will be updated
Docs
Not yet