Implement the Astro.request RFC #2913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 093bf9a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
bholmesdev
approved these changes
Mar 28, 2022
| /** set props for this astro component (along with default values) */ | ||
| props: Record<string, number | string | any>; | ||
| /** get information about this page */ | ||
| request: AstroRequest; | ||
| request: Request; |
There was a problem hiding this comment.
seriously, it's the little things :)
matthewp
force-pushed
the
astro-request-rfc
branch
from
a574111 to
e16fbab
Compare
FredKSchott
reviewed
Mar 28, 2022
| } | ||
|
|
||
| // Headers are only available when using SSR. | ||
| const request = createRequest({ |
There was a problem hiding this comment.
TIL that Node.js http.IncomingMessage wasn't a Request object... For some reason I thought that that had always been the case!
FredKSchott
approved these changes
Mar 28, 2022
|
Did my best to fix merge conflicts for you. If you need to, you can force-push your local branch back up github to revert my fixes. |
Merged
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* Implement the Astro.request RFC * Disable console warnings eslint * Use our logger * Adds a changeset * Fix tests that depend on params, canonicalURL, URL Co-authored-by: Fred K. Schott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Astro.requestRFC changes: https://github.com/withastro/rfcs/blob/main/proposals/0018-astro-request.mdAstro.request.paramsandAstro.request.canonicalURL.Testing
Tests updated
Docs