Fix adblock issue #2875
Merged
Fix adblock issue #2875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2f4f8d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
FredKSchott
force-pushed
the
fix-adblock-issue
branch
from
711c3e6 to
2f4f8d4
Compare
matthewp
approved these changes
Mar 24, 2022
natemoo-re
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
It's a small shame to lose fidelity here, but I think it's worth it. Alternatively, we could let you pass along Vite's rollup options in your astro config and leave this fix to user-land, but I think we can treat the two ideas separately. AKA even if we did support pass along options, I think this still makes sense as the default behavior for this reason.
I attempted to write my own sanitizer but realized we'd never reach parity with every ad blocker around.
Testing
Docs