Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for blog and docs examples #2373

Merged
merged 5 commits into from
Jan 14, 2022
Merged

Fixes for blog and docs examples #2373

merged 5 commits into from
Jan 14, 2022

Conversation

matthewp
Copy link
Contributor

Changes

Testing

Tests added

Docs

Bug fix

@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2022

🦋 Changeset detected

Latest commit: 7200a62

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) test labels Jan 13, 2022
@netlify
Copy link

netlify bot commented Jan 13, 2022

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: 7d640a4

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61e070c8705d9e000845e17d

😎 Browse the preview: https://deploy-preview-2373--astro-docs-2.netlify.app

@netlify
Copy link

netlify bot commented Jan 13, 2022

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: 7a523da

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61e070ea38ace7000839be6d

😎 Browse the preview: https://deploy-preview-2373--astro-docs-2.netlify.app

Copy link
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two nits! Love to see the added tests and astro improvements coming out of this.

examples/blog/src/pages/index.astro Outdated Show resolved Hide resolved
@matthewp matthewp merged commit 92532b8 into main Jan 14, 2022
@matthewp matthewp deleted the sb-blog-docs branch January 14, 2022 17:11
@github-actions github-actions bot mentioned this pull request Jan 14, 2022
matthewp added a commit that referenced this pull request Jan 14, 2022
* [ci] collect stats

* [ci] update lockfile (#2388)

Co-authored-by: FredKSchott <[email protected]>

* Fixes for blog and docs examples (#2373)

* Fixes for blog and docs examples

* Adds a changeset

* Upgrade the compiler version

* Use a global style tag

* Skip on windows temporarily

* [ci] yarn format

* Fixes Lit support in the static build

* Adds a changeset

* test

* Upgrade lit-labs/ssr

* Conditional

* Testing again

* remove debugging code

* changeset

Co-authored-by: FredKSchott <[email protected]>
Co-authored-by: Fred K. Schott <[email protected]>
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Fixes for blog and docs examples

* Adds a changeset

* Upgrade the compiler version

* Use a global style tag

* Skip on windows temporarily
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* [ci] collect stats

* [ci] update lockfile (withastro#2388)

Co-authored-by: FredKSchott <[email protected]>

* Fixes for blog and docs examples (withastro#2373)

* Fixes for blog and docs examples

* Adds a changeset

* Upgrade the compiler version

* Use a global style tag

* Skip on windows temporarily

* [ci] yarn format

* Fixes Lit support in the static build

* Adds a changeset

* test

* Upgrade lit-labs/ssr

* Conditional

* Testing again

* remove debugging code

* changeset

Co-authored-by: FredKSchott <[email protected]>
Co-authored-by: Fred K. Schott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants