-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with plugins running twice in dev and build #2323
Conversation
🦋 Changeset detectedLatest commit: a7c4938 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✔️ Deploy Preview for astro-www ready! 🔨 Explore the source changes: a7c4938 🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-www/deploys/61d8c5fdc6768b000867cd95 😎 Browse the preview: https://deploy-preview-2323--astro-www.netlify.app |
✔️ Deploy Preview for astro-docs-2 ready! 🔨 Explore the source changes: 814ffc5 🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61d60cb3a023cc0008b0f272 😎 Browse the preview: https://deploy-preview-2323--astro-docs-2.netlify.app/en/guides/markdown-content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! for history, can you leave a comment here in GH just to confirm why astroConfig.vite
is no longer needed?
remember to add changeset! I'll add one for you here |
Talked on discord, merging now to unblock #2185 for a user in discord. I'm also +1 on the cleanup suggested but that can happen in a followup PR |
* Fix issue with plugins running twice in dev and build * nit: only patch plugins * nit: only patch plugins * nit: only solve for create-vite * nit: only solve for create-vite * Create seven-mice-do.md Co-authored-by: Fred K. Schott <[email protected]>
* Fix issue with plugins running twice in dev and build * nit: only patch plugins * nit: only patch plugins * nit: only solve for create-vite * nit: only solve for create-vite * Create seven-mice-do.md Co-authored-by: Fred K. Schott <[email protected]>
Changes
Testing
bug fix only
Docs
bug fix only