Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with plugins running twice in dev and build #2323

Merged
merged 6 commits into from
Jan 7, 2022

Conversation

jonathantneal
Copy link
Contributor

@jonathantneal jonathantneal commented Jan 5, 2022

Changes

  • Fixes an issue where Vite Plugins are run twice.
  • Hopefully improves plugin performance.

Testing

bug fix only

Docs

bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2022

🦋 Changeset detected

Latest commit: a7c4938

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 5, 2022
@netlify
Copy link

netlify bot commented Jan 5, 2022

✔️ Deploy Preview for astro-www ready!

🔨 Explore the source changes: a7c4938

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-www/deploys/61d8c5fdc6768b000867cd95

😎 Browse the preview: https://deploy-preview-2323--astro-www.netlify.app

@netlify
Copy link

netlify bot commented Jan 5, 2022

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: 814ffc5

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61d60cb3a023cc0008b0f272

😎 Browse the preview: https://deploy-preview-2323--astro-docs-2.netlify.app/en/guides/markdown-content

@jonathantneal jonathantneal marked this pull request as ready for review January 5, 2022 23:49
Copy link
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! for history, can you leave a comment here in GH just to confirm why astroConfig.vite is no longer needed?

@FredKSchott
Copy link
Member

remember to add changeset! I'll add one for you here

@FredKSchott FredKSchott merged commit 69af658 into main Jan 7, 2022
@FredKSchott FredKSchott deleted the jn.fix-dupe-plugin-runs branch January 7, 2022 23:00
@FredKSchott
Copy link
Member

Talked on discord, merging now to unblock #2185 for a user in discord. I'm also +1 on the cleanup suggested but that can happen in a followup PR

@github-actions github-actions bot mentioned this pull request Jan 7, 2022
jonathantneal added a commit that referenced this pull request Jan 8, 2022
* Fix issue with plugins running twice in dev and build

* nit: only patch plugins

* nit: only patch plugins

* nit: only solve for create-vite

* nit: only solve for create-vite

* Create seven-mice-do.md

Co-authored-by: Fred K. Schott <[email protected]>
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Fix issue with plugins running twice in dev and build

* nit: only patch plugins

* nit: only patch plugins

* nit: only solve for create-vite

* nit: only solve for create-vite

* Create seven-mice-do.md

Co-authored-by: Fred K. Schott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants