Repository navigation
Narrow optimizeDeps.include glob to JS files only in Cloudflare adapter - #18091
Merged
Merged
Conversation
1 task done
🦋 Changeset detectedLatest commit: 7ddac50 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthewp
approved these changes
Sep 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
optimizeDeps.includeglob in the Cloudflare adapter'sconfigEnvironmenthook from'astro/runtime/**'to'astro/runtime/**/*.js'. Vite expands the glob against astro's exports map ("./runtime/*": "./dist/runtime/*"), which previously matched all 166 files indist/runtime/— including 83.d.tsdeclaration files. Each.d.tsbecame an esbuild entry that produced an empty chunk, adding ~83 unnecessary optimizer entries and ~78 zero-byte files per environment on every cold optimize run..d.tsfiles are excluded entirely. Optimizer entry counts drop from 209 → 126 (deps_astro) and 806 → 723 (deps_ssr); all 83 runtime.jsmodules remain pre-bundled and pages render correctly.Testing
packages/integrations/cloudflare/test/units/optimize-deps-glob.test.ts, a unit test that verifies the glob inoptimizeDeps.includematches only.jsfiles and excludes.d.tsentries.Docs
Closes #18090