Filter out invalid same-axis `object-position` pairs in responsive image styles by astro-factory[bot] · Pull Request #18043 · withastro/astro

astro-factory · 2026-09-17T14:23:10Z

Changes

When image.responsiveStyles is enabled, getPositionEntries() no longer emits the four invalid two-keyword object-position combinations where both keywords share the same axis (top bottom, bottom top, left right, right left). These values are rejected by browsers and CSS validators per the CSS Images Level 3 <position> grammar.
The fix adds two axis sets (VERTICAL_ONLY = {top, bottom}, HORIZONTAL_ONLY = {left, right}) and skips any generated pair where both keywords belong to the same set. All valid cross-axis combinations and center-inclusive pairs are preserved.

Testing

Added a unit test in packages/astro/test/units/assets/utils.test.ts ('does not emit invalid same-axis position pairs') that asserts none of the four invalid pairs appear in the output of getPositionEntries().

Docs

No docs update needed; this is a bug fix for invalid CSS output with no API or behavior change visible to users.

Closes #18042

…ion` values

changeset-bot · 2026-09-17T14:23:25Z

🦋 Changeset detected

Latest commit: 2ef367e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Assert all 16 valid cross-axis two-keyword pairs are emitted (both keyword orders, selector and declaration) and that the 4 invalid same-axis pairs are absent as both selectors and declarations.

codspeed · 2026-09-17T14:35:22Z

Merging this PR will not alter performance

✅ 21 untouched benchmarks

_{Comparing factory/fix-18042 (2ef367e) with main (ec27992)¹}

No successful run was found on main (1aa7ae5) during the generation of this report, so ec27992 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [astro](https://astro.build) ([source](https://github.com/withastro/astro/tree/HEAD/packages/astro)) | [`7.3.3` → `7.3.4`](https://renovatebot.com/diffs/npm/astro/7.3.3/7.3.4) | ![age](https://developer.mend.io/api/mc/badges/age/npm/astro/7.3.4?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/astro/7.3.3/7.3.4?slim=true) | --- ### Release Notes <details> <summary>withastro/astro (astro)</summary> ### [`v7.3.4`](https://github.com/withastro/astro/blob/HEAD/packages/astro/CHANGELOG.md#734) [Compare Source](https://github.com/withastro/astro/compare/astro@7.3.3...astro@7.3.4) ##### Patch Changes - [#18063](withastro/astro#18063) [`40896ac`](withastro/astro@40896ac) Thanks [@adamchal](https://github.com/adamchal)! - Fixes incremental builds repeatedly rendering unchanged pages when modules or compiled CSS reference bundled assets. - [#18053](withastro/astro#18053) [`cf5d72f`](withastro/astro@cf5d72f) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Improves the `astro check` error shown for TypeScript 7. The command now explains that TypeScript 7 is not currently supported and provides instructions for experimentally type-checking Astro files with TypeScript 7.1 and `@astrojs/ts-content-mapper`. - [#18086](withastro/astro#18086) [`795a7e4`](withastro/astro@795a7e4) Thanks [@ump45nose](https://github.com/ump45nose)! - Fix double-escaped ampersands in Markdown image `alt` and `title` attributes. The `__ASTRO_IMAGE_` round-trip now decodes the numeric (`&`) and named (`&`) character references the Markdown processors emit, so an `&` in an alt or title is escaped exactly once in the final HTML instead of twice. - [#18074](withastro/astro#18074) [`0429805`](withastro/astro@0429805) Thanks [@SurefireStudios](https://github.com/SurefireStudios)! - Fix three error names that did not match their documented reference. `MissingLocale`, `MissingIndexForInternationalization` and `NoManifestAvailable` reported names ending in `Error` in the dev overlay, while their error reference pages are published under the unsuffixed names, so the name shown to users could not be found in the docs. - [#18007](withastro/astro#18007) [`2245837`](withastro/astro@2245837) Thanks [@L4XB](https://github.com/L4XB)! - Fixes the dev server re-evaluating the whole server module graph on every request. The `astro:head-metadata` plugin invalidated its component metadata virtual module from its own `transform` hook, so each evaluation of that module scheduled the next one. Adapters that run requests outside Vite's module runner, such as `@astrojs/cloudflare`, paid for a full re-evaluation of the server graph on every request for the lifetime of the process. - [#18096](withastro/astro#18096) [`43657c4`](withastro/astro@43657c4) Thanks [@matthewp](https://github.com/matthewp)! - Fixes domain-based i18n routing to respect `security.allowedDomains` when selecting a locale from request host headers - [#18043](withastro/astro#18043) [`8a53a8b`](withastro/astro@8a53a8b) Thanks [@astro-factory](https://github.com/apps/astro-factory)! - Fixes `image.responsiveStyles` emitting invalid `object-position` CSS values for same-axis keyword pairs (`top bottom`, `left right`, etc.) - [#18029](withastro/astro#18029) [`c08252d`](withastro/astro@c08252d) Thanks [@matthewp](https://github.com/matthewp)! - Runs `astro dev` and `astro preview` in the foreground when an AI agent is detected on Windows, allowing the agent to manage the process lifetime. Pass `--background` explicitly to request an Astro-managed background process. Agent-inferred backgrounding remains enabled on other platforms. - Updated dependencies \[[`3fd16ee`](withastro/astro@3fd16ee), [`8358d59`](withastro/astro@8358d59)]: - [@astrojs/markdown-satteri](https://github.com/astrojs/markdown-satteri)@0.4.2 </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).

Fix image.responsiveStyles emitting invalid same-axis `object-posit…

366c3be

…ion` values

astro-factory Bot added the fix verified Reporter confirmed the triage bot fix works label Sep 17, 2026

astro-factory Bot mentioned this pull request Sep 17, 2026

Regression (6.3.5): image.responsiveStyles emits invalid object-position #18042

Closed

1 task done

github-actions Bot added the pkg: astro Related to the core `astro` package (scope) label Sep 17, 2026

test(assets): strengthen responsiveStyles object-position tests

2ef367e

Assert all 16 valid cross-axis two-keyword pairs are emitted (both keyword orders, selector and declaration) and that the 4 invalid same-axis pairs are absent as both selectors and declarations.

matthewp approved these changes Sep 17, 2026

View reviewed changes

matthewp merged commit 8a53a8b into main Sep 17, 2026
29 checks passed

matthewp deleted the factory/fix-18042 branch September 17, 2026 15:31

astrobot-houston mentioned this pull request Sep 17, 2026

[ci] release #18035

Merged

Navigation Menu

Repository navigation

Filter out invalid same-axis `object-position` pairs in responsive image styles - #18043

Filter out invalid same-axis `object-position` pairs in responsive image styles#18043
matthewp merged 2 commits into
mainfrom
factory/fix-18042

astro-factory Bot commented Sep 17, 2026

Uh oh!

changeset-bot Bot commented Sep 17, 2026 •

edited

Loading

Uh oh!

codspeed Bot commented Sep 17, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

astro-factory Bot commented Sep 17, 2026

Changes

Testing

Docs

Uh oh!

changeset-bot Bot commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

codspeed Bot commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

changeset-bot Bot commented Sep 17, 2026 •

edited

Loading

codspeed Bot commented Sep 17, 2026 •

edited

Loading