Repository navigation
fix(cloudflare): preserve passthrough image service in compile mode - #18032
Conversation
🦋 Changeset detectedLatest commit: c16ad0a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@matthewp My concern with #18031 is that it overrides behavior and warns for all custom image services. This PR targets The warning runs in Endpoint selection still happens early. That means an integration-added passthrough service can miss the override: the build warning can detect the conflicting runtime configuration, but it doesn’t fix endpoint selection in that case. Dev requests—and production requests when using the binding runtime—can still fail. I considered appending a separate integration to apply the override later, but that doesn’t guarantee ordering either. I’ve kept this fix scoped to directly configured passthrough rather than expanding it into a general solution for integration ordering. The added tests cover passthrough precedence in dev and build. I didn’t add separate warning coverage. The focus is the endpoint behavior. |
|
Sounds good, I'll close that one. |
Changes
passthroughImageService()precedence when usingimageService: 'compile', fixing image requests during development and on-demand rendering.runtime: 'cloudflare-binding'.Testing
'compile'.Docs
N/a
Closes #17968