Fix incremental build cache invalidation caused by Shiki mutating the langAlias config object - #17696
Merged
Conversation
…vent config mutation (#17693)
1 task
🦋 Changeset detectedLatest commit: f74a04b The changes in this PR will be included in the next version bump. This PR includes changesets to release 433 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthewp
approved these changes
Aug 14, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
langAliasbefore passing it to Shiki'screateHighlighter()inpackages/internal-helpers/src/shiki.ts. Shiki'sRegistry.loadLanguage()writes built-in language aliases (e.g.js,cjs,mjsfor JavaScript) directly into thelangAliasobject it receives. Because Astro passed the same object reference from the resolved config, those aliases leaked back intoconfig.markdown.shikiConfig.langAlias. SincecomputeConfigHash()runs after the Vite build, the hash then reflected which languages appeared in code blocks rather than the user's actual config, causing the incremental build cache to be invalidated on every content change.Closes #17693
Testing
packages/internal-helpers/test/shiki.test.tswith a test that highlights a JavaScript code block and asserts the originallangAliasobject passed tocreateShikiHighlighteris not mutated.Docs