Skip to content

chore(deps): remove redundant pnpm overrides#16732

Merged
matthewp merged 2 commits into
withastro:mainfrom
ocavue-forks:ocavue/deps-vite7-override
May 14, 2026
Merged

chore(deps): remove redundant pnpm overrides#16732
matthewp merged 2 commits into
withastro:mainfrom
ocavue-forks:ocavue/deps-vite7-override

Conversation

@ocavue
Copy link
Copy Markdown
Contributor

@ocavue ocavue commented May 14, 2026

Changes

Removes overrides field in pnpm-workspace.yaml. This is a follow-up to #16716 (comment)

  1. Remove overrides > vite. This is required for the branch next where we don't want to install vite v7 at all.

  2. Remove overrides > picomatch. This resolves the peer dep warning below:

    Before:

    $ pnpm --version
    11.0.9
    $ pnpm peers check
    Issues with peer dependencies found
    
    ✕ unmet peer picomatch
      Installed: 4.0.4
      Wanted:
        ^2.3.2:
          fdir@6.5.0
    
    ✕ unmet peer zod
      Installed: 4.3.6
      Wanted:
        ^3.22.4:
          simple-stack-form@0.1.12
    
    ✕ unmet peer @cloudflare/workers-types
      Installed: 4.20260228.0
      Wanted:
        ^4.20260415.1:
          wrangler@4.83.0

    After:

    $ pnpm --version
    11.0.9
    $ pnpm peers check
    Issues with peer dependencies found
    
    ✕ unmet peer zod
      Installed: 4.3.6
      Wanted:
        ^3.22.4:
          simple-stack-form@0.1.12
    
    ✕ unmet peer @cloudflare/workers-types
      Installed: 4.20260228.0
      Wanted:
        ^4.20260415.1:
          wrangler@4.83.0

Sometimes overrides field is required to tweak pnpm-lock.yaml, however, in general, it should not remain in the repository if pnpm-lock.yaml remains valid after removing overrides.

Testing

CI should pass

Docs

N/A

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 14, 2026

⚠️ No Changeset found

Latest commit: a2f7a00

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ocavue ocavue marked this pull request as ready for review May 14, 2026 07:34
Copy link
Copy Markdown
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@matthewp matthewp merged commit b91cb45 into withastro:main May 14, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants