fix(upgrade): fix test types

[ocavue]

Changes

1. Removed noEmit: true from packages/upgrade/tsconfig.json. This actually reveals the following error in CI. This is an old bug but since we didn't emit .d.ts files we didn't find it out.

@astrojs/upgrade@0.7.2 : typecheck:tests packages/upgrade
  
  > @astrojs/upgrade@0.7.2 typecheck:tests /home/runner/work/astro/astro/packages/upgrade
  > tsc --build tsconfig.test.json
  
  Error: test/install.test.ts(30,17): error TS2345: Argument of type '{ packages: { name: string; currentVersion: string; targetVersion: string; }[]; cwd: string; version: string; packageManager: string; dryRun: boolean; }' is not assignable to parameter of type 'Pick<Context, "version" | "packages" | "packageManager" | "prompt" | "dryRun" | "exit" | "cwd">'.
    Type '{ packages: { name: string; currentVersion: string; targetVersion: string; }[]; cwd: string; version: string; packageManager: string; dryRun: boolean; }' is missing the following properties from type 'Pick<Context, "version" | "packages" | "packageManager" | "prompt" | "dryRun" | "exit" | "cwd">': prompt, exit

2. Actually fix the TS typing so that this error is gone.

Testing

Docs

[changeset-bot]

⚠️ No Changeset found

Latest commit: 47915d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[ocavue]

1. upgrade.js is a mistake. That file has been renamed to upgrade.mjs.

2. Since @astrojs/upgrade is a CLI, we probably don't want to ship dist/**/*.d.ts files to the NPM registry. Maybe that's why we had noEmit: true in the first place. Anyway, I get rid of all dist/**/*.d.ts files when publishing by only including .js and .mjs files.

   (We currently only emit .js files; I added .mjs just in case we want to ship .mjs files in the future)