Skip to content

fix: internal header leak#15718

Merged
florian-lefebvre merged 1 commit intomainfrom
fix/internal-header-leak
Mar 2, 2026
Merged

fix: internal header leak#15718
florian-lefebvre merged 1 commit intomainfrom
fix/internal-header-leak

Conversation

@florian-lefebvre
Copy link
Member

Changes

  • Internal headers could sometimes leak when rendering error pages
  • This PR improves the logic to always clean the response and makes sure we now pass render options down properly

Testing

Updated

Docs

Changeset

@florian-lefebvre florian-lefebvre self-assigned this Mar 2, 2026
@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2026

🦋 Changeset detected

Latest commit: 8ef4585

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 2, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 2, 2026

Merging this PR will not alter performance

✅ 18 untouched benchmarks


Comparing fix/internal-header-leak (8ef4585) with main (829182b)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (20dc768) during the generation of this report, so 829182b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@florian-lefebvre florian-lefebvre marked this pull request as ready for review March 2, 2026 16:03
@florian-lefebvre florian-lefebvre merged commit 14f37b8 into main Mar 2, 2026
26 checks passed
@florian-lefebvre florian-lefebvre deleted the fix/internal-header-leak branch March 2, 2026 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants