Skip to content

feat(node)!: remove experimentalErrorPageHost#15654

Merged
florian-lefebvre merged 5 commits intomainfrom
feat/node-remove-experimental-error-page-host
Mar 2, 2026
Merged

feat(node)!: remove experimentalErrorPageHost#15654
florian-lefebvre merged 5 commits intomainfrom
feat/node-remove-experimental-error-page-host

Conversation

@florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Feb 25, 2026

Changes

  • From @matthewp: "while you're in there I would remove experimentalErrorPageHost which is a security nightmare"
  • So this removes the option

Testing

Improves our tests to still check we read files from the filesystem

Docs

@florian-lefebvre florian-lefebvre self-assigned this Feb 25, 2026
@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2026

🦋 Changeset detected

Latest commit: 892eda4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Feb 25, 2026
@florian-lefebvre florian-lefebvre marked this pull request as ready for review February 25, 2026 08:29
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Florian! Just a couple thoughts from me!

florian-lefebvre and others added 2 commits February 26, 2026 09:37
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
@florian-lefebvre
Copy link
Member Author

@sarah11918 I'd like your input on the updated changeset

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, Florian! Just a tiny verb tense fix!

Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
@florian-lefebvre florian-lefebvre merged commit a32aee6 into main Mar 2, 2026
9 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/node-remove-experimental-error-page-host branch March 2, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: integration Related to any renderer integration (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants