fix(markdown-remark): reuse shiki highlighter instance#15651
Merged
ematipico merged 8 commits intowithastro:mainfrom Feb 27, 2026
Merged
fix(markdown-remark): reuse shiki highlighter instance#15651ematipico merged 8 commits intowithastro:mainfrom
ematipico merged 8 commits intowithastro:mainfrom
Conversation
🦋 Changeset detectedLatest commit: b0e5acd The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
f8c100c to
ae94c68
Compare
ae94c68 to
555e443
Compare
1 task
ematipico
reviewed
Feb 25, 2026
Comment on lines
+100
to
+101
| Object.entries(options?.themes ?? {}).sort(), | ||
| Object.entries(options?.langAlias ?? {}).sort(), |
Member
There was a problem hiding this comment.
This is wasteful because we're polluting the key with empty objects. I suggest looking for a different approach e.g.
const keyCache = [];
if (options?.theme) { keyCache.push(options.theme) }
...
const key = keyCache.length > 0 ? JSON.stringify() : "";
ematipico
approved these changes
Feb 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Closes #15656
I noticed the following warning in my Astro project:
This is due to the fact that Astro creates a new Shiki highlighter instance for each language, and there are many different code block languages in my project.
This PR improves this by using the same highlighter across languages. This approach works because Astro already loads languages dynamically when they haven't been loaded yet (code link).
Testing
Added a new test to ensure that
Docs
Changeset file has been added.