Repository navigation
Conversation
Fixes withastro#15420 The --add flag was passing user input directly to shell commands, allowing shell metacharacters to be interpreted. This adds validation to ensure integration names match the npm package name pattern before passing them to the shell. - Added VALID_INTEGRATION_NAME regex pattern for npm package names - Added isValidIntegrationName() validation function - Invalid integration names are filtered out with an error message - Added tests for validation behavior
github-actions
Bot
added
the
pkg: create-astro
🦋 Changeset detectedLatest commit: 21e445a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
Hi, this was already fixed by #15419 unfortunately. Thanks for trying! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15420
The
--addflag was passing user input directly to shell commands, allowing shell metacharacters to be interpreted as shell syntax. For example:npm create --yes astro poc -- --add "react; open -a Calculator.app;" --install --yesWould result in
open -a Calculator.appbeing executed.Changes
VALID_INTEGRATION_NAMEregex pattern that matches valid npm package names (lowercase letters, numbers, hyphens, underscores, dots, and scoped packages)isValidIntegrationName()validation functionTesting
All 73 tests pass, including the 3 new tests:
rejects integration names with shell metacharacters✔accepts valid integration names✔filters out only invalid integration names✔