Repository navigation
Conversation
|
ocavue
marked this pull request as ready for review
December 5, 2025 01:02
Contributor
|
| 📦 Package | 🔒 Before | 🔓 After |
|---|---|---|
| @cloudflare/unenv-preset | trusted-with-provenance | none |
| workerd | trusted-with-provenance | none |
| ts-api-utils | provenance | none |
| undici | provenance | none |
| miniflare | trusted-with-provenance | none |
| youch | provenance | none |
| @cloudflare/workerd-darwin-64 | trusted-with-provenance | none |
| @cloudflare/workerd-darwin-arm64 | trusted-with-provenance | none |
| @cloudflare/workerd-linux-64 | trusted-with-provenance | none |
| @cloudflare/workerd-linux-arm64 | trusted-with-provenance | none |
| @cloudflare/workerd-windows-64 | trusted-with-provenance | none |
| wrangler | trusted-with-provenance | none |
Contributor
Author
|
see #14821 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When updating
@sveltejs/vite-plugin-sveltefrom v5 to v6, the build fails with a parsing error:Root cause:
pluginComponentEntrycreates virtual modules like\0astro-entry:.../Component.sveltecontaining re-export statements.In
@sveltejs/vite-plugin-sveltev6, these modules are incorrectly treated as Svelte components due to the.svelteextension, causing parse errors.In
@sveltejs/vite-plugin-sveltev5, these modules are ignored because the module id contains\0and get filtered out at createFilter.ts#L51.See also: changelog for
@sveltejs/vite-plugin-sveltev6.0.0Solution: Add a
.jssuffix to virtual entry modules for non-JS files (like.svelte,.vue, etc.) to ensure that SFC plugins won't mistakenly process them as components.This fix is applicable to all UI frameworks with custom file extensions, including Vue, Svelte, Marko, Riot, Ripple, and any other SFC framework that may arise in the future.
Testing
All existing tests pass.
Docs
No docs/changeset added because there are no changes to the public API. The
pluginComponentEntryis just an implementation detail.(I can add a changeset if the Astro team thinks it's necessary.)