Fix remaining cloudflare tests by matthewp · Pull Request #14912 · withastro/astro

matthewp · 2025-11-26T16:08:55Z

Changes

Removes the platform proxy, uses request.cf and import { env } from 'cloudflare:workers' instead.

Testing

Cloudflare tests not all pass
The response from workerd is different in one of the test, updated that, but functionally the same.

Docs

N/A

changeset-bot · 2025-11-26T16:09:01Z

⚠️ No Changeset found

Latest commit: 1555879

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

.changeset/open-monkeys-boil.md

florian-lefebvre · 2025-11-28T14:58:50Z

packages/integrations/cloudflare/src/utils/handler.ts


-export interface Runtime<T extends object = object> {
+export interface Runtime {
 	runtime: {


I think we may want to change this object shape? locals.runtime.ctx may not make a lot of sense anymore. What about, idk, locals.cfContext?

I thought about something like that, but given that Astro.locals.runtime is already a existing object for the cloudflare integration and the variable is always documented as ctx I thought just making this as backwards compat as possible, for now, would be best.

Given we remove all other properties already, not sure I agree. I'd say we should either keep everything and deprecate things if needed for backward compatibility, or start clean and design the API as we'd like it ideally

ok i switched to cfContext

packages/integrations/cloudflare/types.d.ts

packages/integrations/cloudflare/src/types.d.ts

florian-lefebvre · 2025-11-28T15:45:50Z

packages/integrations/cloudflare/src/index.ts


+				injectTypes({
+					filename: 'cloudflare.d.ts',
+					content: '/// <reference types="@astrojs/cloudflare/types.d.ts" />',


You may need to update the package.json exports to make it work

done, thanks

Co-authored-by: Emanuele Stoppa <my.burning@gmail.com> Co-authored-by: Samuel Macleod <smacleod@cloudflare.com> Co-authored-by: Alexander Niebuhr <alexander@nbhr.io> Co-authored-by: ascorbic <213306+ascorbic@users.noreply.github.com> Co-authored-by: matthewp <361671+matthewp@users.noreply.github.com> Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev> Co-authored-by: Matt Kane <m@mk.gg> Co-authored-by: florian-lefebvre <69633530+florian-lefebvre@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Matthew Phillips <matthew@skypack.dev> Co-authored-by: Matthew Phillips <matthew@skypack.dev> Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com> Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com> Co-authored-by: Hayato Hasegawa <hase1225hayato@gmail.com> fix: creation of routes list in build (#14325) Fix unit tests for environment API (#14394) fixture (#14599) fix: organize imports and formatting in cloudflare handler (#14697) fix: resolve environment-api build issues for client & CSS (#14770) Fixes CSS when both static/client styles exist (#14790) fix: flag `serverLike` incorrectly computed (#14792) fix: redirects and i18n routing (#14797) fix: logger level and static paths params (#14799) Fix image tests crashing (#14803) fix(environment): Error overlay not working (#14816) fix: hashing of chunks (#14811) Fix before-hydration script emission for environment-api (#14818) fix: node leak into content collections (#14820) fix: avoid `node:path` (#14827) Fix API route tests (#14825) Fix unit tests (#14832) fix: server islands build (#14830) Fix astro-component-bundling tests (#14840) Fix astro-component-bundling tests (#14837) Fix config alias by using resolve.alias config (#14828) fix: container and routing tests (#14852) fix: respect user vite config on sourcemaps (#14847) fix: remove useless tests (#14854) Fixes assetQueryParams and public folder tests (#14853) fix: renderError fallback (#14855) Fix server-islands data being used across tests (#14857) fix: incorrect configuration in tests (#14858) Fixes for tests in environment branch (#14865) Fixes for e2e tests in environment branch (#14870) fix(test): svelte async rendering (#14886) fix(cloudflare/vercel/netlify): some tests pass and excluded others (#14892) Fixes for node integrations tests (#14900) Fix @astrojs/db tests (#14899) fix(environment): Prevent Vite from interpreting injected sourcemap comments as actual sourcemaps (#14921) Fix remaining cloudflare tests (#14912) fix(vite): import mergeConfig from direct file to avoid dynamic import being processed by Vite (#14939) Fix astro:env tests in Cloudflare (#14925)

Fix remaining cloudflare tests

9a09692

github-actions bot added the pkg: integration Related to any renderer integration (scope) label Nov 26, 2025

matthewp added 10 commits November 26, 2025 11:28

testing

844e11e

just a test

58c2db5

try this

afdab2e

lean into cloudflare:workers

684c959

add types

489a6fe

completely remove the platform proxy stuff

8eac286

Merge branch 'feat/environment-api' into tests/env-cloudflare-2

a1fb870

changeset stuff

d6af253

prime the preloading

2686535

fix windows

b4bcdb1

matthewp marked this pull request as ready for review November 28, 2025 14:46

florian-lefebvre reviewed Nov 28, 2025

View reviewed changes

pr comments

88b0eee

florian-lefebvre reviewed Nov 28, 2025

View reviewed changes

matthewp added 5 commits November 28, 2025 10:52

change to cfContext

6774d26

update the changeset

aa49219

add export

d0b4ca3

fix build

40324f5

fix linting

1555879

matthewp merged commit 3e172ef into feat/environment-api Nov 28, 2025
21 checks passed

matthewp deleted the tests/env-cloudflare-2 branch November 28, 2025 16:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix remaining cloudflare tests#14912

Fix remaining cloudflare tests#14912
matthewp merged 17 commits intofeat/environment-apifrom
tests/env-cloudflare-2

matthewp commented Nov 26, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Nov 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

florian-lefebvre Nov 28, 2025

Uh oh!

matthewp Nov 28, 2025

Uh oh!

florian-lefebvre Nov 28, 2025 •

edited

Loading

Uh oh!

matthewp Nov 28, 2025

Uh oh!

Uh oh!

Uh oh!

florian-lefebvre Nov 28, 2025

Uh oh!

matthewp Nov 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

matthewp commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Testing

Docs

Uh oh!

changeset-bot bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Uh oh!

florian-lefebvre Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

matthewp Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

florian-lefebvre Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

matthewp Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

florian-lefebvre Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

matthewp Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

matthewp commented Nov 26, 2025 •

edited

Loading

changeset-bot bot commented Nov 26, 2025 •

edited

Loading

florian-lefebvre Nov 28, 2025 •

edited

Loading