Skip to content

Conversation

@florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Nov 25, 2025

Changes

Testing

Type tests

Docs

withastro/docs#12797

@florian-lefebvre florian-lefebvre added this to the v6.0.0 milestone Nov 25, 2025
@florian-lefebvre florian-lefebvre self-assigned this Nov 25, 2025
@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2025

⚠️ No Changeset found

Latest commit: 2d293e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 25, 2025
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you @florian-lefebvre

I believe we actually have a test that still uses the incorrect configuration (we fixed in feat/environment-api but not in next)

@florian-lefebvre
Copy link
Member Author

Perfect, we'll see if it works then!

@florian-lefebvre
Copy link
Member Author

florian-lefebvre commented Nov 26, 2025

Actually it doesn't catch the test failure because redirectToDefaultLocale wasn't provided at all altough it's required by the types

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed as requested!

@florian-lefebvre florian-lefebvre merged commit 8c7cf89 into next Dec 4, 2025
20 of 21 checks passed
@florian-lefebvre florian-lefebvre deleted the fix/i18n-middleware-impossible-config branch December 4, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs pr pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants