-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix: i18n middleware impossible config #14890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ematipico
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thank you @florian-lefebvre
I believe we actually have a test that still uses the incorrect configuration (we fixed in feat/environment-api but not in next)
|
Perfect, we'll see if it works then! |
|
Actually it doesn't catch the test failure because |
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed as requested!
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Changes
Testing
Type tests
Docs
withastro/docs#12797